-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react 18 antd5 #1375
Update react 18 antd5 #1375
Conversation
packages/uniforms-antd/package.json
Outdated
"@ant-design/icons": "^5.0.0", | ||
"antd": "^5.0.0", | ||
"dayjs": "^1.11.13", | ||
"rc-input-number": "^9.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes
The inferred type of 'default' cannot be named without a reference to '.pnpm/[email protected][email protected][email protected][email protected]/node_modules/rc-input-number'. This is likely not portable. A type annotation is necessary.ts(2742)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this differently.
- Keep
[email protected]
only indevDependencies
- Add
/// <reference types="rc-input-number" />
to theNumField
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- AntD tests are skipped. You need to remove
.skip
from them. 5 AntD tests fail. - By the way, our CI fails, so we need to adjust other tests as well. EDIT: This is caused by using
npm
by CI. Let's fix that at the end. - Add meaningful pull request description
packages/uniforms-antd/package.json
Outdated
"@ant-design/icons": "^5.0.0", | ||
"antd": "^5.0.0", | ||
"dayjs": "^1.11.13", | ||
"rc-input-number": "^9.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this differently.
- Keep
[email protected]
only indevDependencies
- Add
/// <reference types="rc-input-number" />
to theNumField
file
7aa9e7c
to
e090090
Compare
Based on the
update-react
branch. Update React to v18 in theuniforms-antd
package. Updating AntD to v5 is required.