Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react 18 antd5 #1375

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Update react 18 antd5 #1375

merged 5 commits into from
Oct 28, 2024

Conversation

kestarumper
Copy link
Member

@kestarumper kestarumper commented Oct 25, 2024

Based on the update-react branch. Update React to v18 in the uniforms-antd package. Updating AntD to v5 is required.

@kestarumper kestarumper added the Theme: AntD Affects the uniforms-antd package label Oct 25, 2024
@github-actions github-actions bot added the Area: Theme Affects some of the theme packages label Oct 25, 2024
"@ant-design/icons": "^5.0.0",
"antd": "^5.0.0",
"dayjs": "^1.11.13",
"rc-input-number": "^9.2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes

The inferred type of 'default' cannot be named without a reference to '.pnpm/[email protected][email protected][email protected][email protected]/node_modules/rc-input-number'. This is likely not portable. A type annotation is necessary.ts(2742)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this differently.

  1. Keep [email protected] only in devDependencies
  2. Add /// <reference types="rc-input-number" /> to the NumField file

Copy link
Collaborator

@piotrpospiech piotrpospiech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. AntD tests are skipped. You need to remove .skip from them. 5 AntD tests fail.
  2. By the way, our CI fails, so we need to adjust other tests as well. EDIT: This is caused by using npm by CI. Let's fix that at the end.
  3. Add meaningful pull request description

"@ant-design/icons": "^5.0.0",
"antd": "^5.0.0",
"dayjs": "^1.11.13",
"rc-input-number": "^9.2.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this differently.

  1. Keep [email protected] only in devDependencies
  2. Add /// <reference types="rc-input-number" /> to the NumField file

packages/uniforms-antd/package.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Area: Core Affects the uniforms package label Oct 28, 2024
@github-actions github-actions bot added the Area: Infra Affects the repository itself (e.g., CI, dependencies) label Oct 28, 2024
@piotrpospiech piotrpospiech merged commit b4458a9 into update-react Oct 28, 2024
2 of 5 checks passed
@piotrpospiech piotrpospiech deleted the update-react-antd5 branch October 28, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Affects the uniforms package Area: Infra Affects the repository itself (e.g., CI, dependencies) Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants