Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tslib issue #1378

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix tslib issue #1378

merged 2 commits into from
Oct 29, 2024

Conversation

piotrpospiech
Copy link
Collaborator

During a major monorepo refactoring, tslib was moved to devDependencies, but it should be in the dependencies. It causes issue after installing new 4.0.0-beta.1 version.

✘ [ERROR] Could not resolve "tslib"
  node_modules/uniforms-unstyled/esm/RadioField.js:1:23:
    1 │ import { __rest } from "tslib";

Changes

  • Updated changelog
  • Updated uniforms versions to 4.0.0-beta.2
  • Moved tslib to dependencies
  • Updated tslib to 2.8.0

@piotrpospiech piotrpospiech added this to the v4.0 milestone Oct 29, 2024
@piotrpospiech piotrpospiech self-assigned this Oct 29, 2024
@github-actions github-actions bot added Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Area: Bridge Affects some of the bridge packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package Bridge: JSON Schema Affects the uniforms-bridge-json-schema package Bridge: SimpleSchema (v2) Affects the uniforms-bridge-simple-schema-2 package Bridge: Zod Affects the uniforms-bridge-zod package labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (aa38eee) to head (57516f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1378   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         175      175           
  Lines        2867     2867           
  Branches      774      774           
=======================================
  Hits         2739     2739           
  Misses         59       59           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotrpospiech piotrpospiech merged commit bd93a0b into master Oct 29, 2024
6 checks passed
@piotrpospiech piotrpospiech deleted the fix-tslib branch October 29, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Bridge Affects some of the bridge packages Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Bridge: JSON Schema Affects the uniforms-bridge-json-schema package Bridge: SimpleSchema (v2) Affects the uniforms-bridge-simple-schema-2 package Bridge: Zod Affects the uniforms-bridge-zod package Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants