Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved client creation for Azure OpenAI (inc Entra ) #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joslat
Copy link

@joslat joslat commented Nov 11, 2024

Some helpers to manage configuration and improved client creation for Azure, including Entra ID Auth.

Addresses #7
possibly #4 too
:)

@joslat
Copy link
Author

joslat commented Nov 12, 2024

TODO:
Refactor the provided class so it enables an overload for the current methods to follow the signatures/current structure. So we can send the deployment and endpoint in the FromOpenAIModel/FromOpenAIClient - FromOpenAIKey is only valid for OpenAI - we need more for Azure OpenAI.

Based on the feedback from @vbandi : "We have a trio of static methods for constructing the object: FromOpenAIKey, FromAzureCredential, FromOpenIAClient. I'd like to stick with this pattern."

@vbandi
Copy link
Owner

vbandi commented Nov 12, 2024

Thank you @joslat for documenting our discussion!

@vbandi
Copy link
Owner

vbandi commented Nov 24, 2024

@joslat I've merged @WailGree 's Azure solution. Can you please check and see if this covers what you need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants