Only show desktop notification if sync produced any differences (gopa…

…sspw#2627) This simple change will suppress the desktop notification if the diff is zero. Please note that this is not perfect since an even number of additions and removals might add up to zero. Fixes gopasspw#2618 Signed-off-by: Dominik Schulz <[email protected]>
vbargl · Jul 30, 2023 · c0c3336 · c0c3336
1 parent 45aca2a
commit c0c3336
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/internal/action/sync.go b/internal/action/sync.go
@@ -139,7 +139,10 @@ func (s *Action) sync(ctx context.Context, store string) error {
 	} else if numEntries < 0 {
 		diff = fmt.Sprintf(" Removed %d entries", -1*numEntries)
 	}
-	_ = notify.Notify(ctx, "gopass - sync", fmt.Sprintf("Finished. Synced %d remotes.%s", numMPs, diff))
+
+	if numEntries != 0 {
+		_ = notify.Notify(ctx, "gopass - sync", fmt.Sprintf("Finished. Synced %d remotes.%s", numMPs, diff))
+	}
 
 	return nil
 }