Fix "Last Updated" field #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavierMatosD
changed the title
ras0219-msft
approved these changes
Jun 27, 2024
ras0219-msft
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Currently, this bug is blocking the website from updating because it breaks our validation.
Problem:
The "Last Updated" date for packages was being displayed incorrectly. The rebuild script used a shallow clone of the vcpkg repository, resulting in incomplete commit history. This prevented the script from accurately determining the last time each package was updated.
Solution:
Modified rebuild.sh: Removed the
--depth 1option from thegit fetchcommand to fetch the complete vcpkg repository history.Updated generatePackages.js: Modified the getLastModifiedDate function to use
git log -1 --format=%atto retrieve the author date (last modification time) directly from the vcpkg repository's history.Future Work:
Site Validation now takes much more time because of the 2k+
git logoperations. I will open a PR in the future to improve this by checking in a file instead of partying on the git history every time. I will also separate this functionality from the rebuild script to improve determinism.