Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better NPM versions support #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Better NPM versions support #12

wants to merge 3 commits into from

Conversation

algobardo
Copy link

Quick and dirty fixes for #7

Can you have a look ?

@vdurmont
Copy link
Owner

It looks like you have some test failures :( I'll let you see if they can be fixed.

@algobardo
Copy link
Author

removed these tests

  Requirement.buildNPM("1.2.3-2.3.4"),
  Requirement.buildNPM("1.2.3 -2.3.4"),
  Requirement.buildNPM("1.2.3- 2.3.4"),

@vdurmont
Copy link
Owner

vdurmont commented Feb 24, 2017 •
edited
Loading

Well... Removing the tests definitely fixes the test failures but it looks like those tests were legit. Maybe we can try to fix the code instead?

@algobardo
Copy link
Author

Well...they weren't (see https://github.com/npm/node-semver).

hyphen     ::= partial ' - ' partial

@algobardo algobardo mentioned this pull request Aug 10, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algobardo @vdurmont @mtorp