feat: add OCI registry support for Helm chart #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszwedko
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Thanks @domolitom ! I think we need to add permissions to push to GHR via:
permissions:
packages: write
|
@jszwedko good point! Sorry about that :) It is fixed now. |
jszwedko
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks @domolitom ! We are releasing Vector v0.42.0 today so we can see if this works as expected.
|
@domolitom the latest release was published to ghcr! Thanks again for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #418
Before merging this PR, probably an admin needs to permit this repository on Github Packages to have permission to push.