Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Telegraf features to README #15585

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Dec 14, 2022

Closes #14475

@bits-bot
Copy link

bits-bot commented Dec 14, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit a96874f
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/639a062c912a240008504a1b

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for vrl-playground ready!

Name Link
🔨 Latest commit a96874f
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/639a062cdf45c900085a7f5b
😎 Deploy Preview https://deploy-preview-15585--vrl-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tobz
Copy link
Contributor

tobz commented Dec 14, 2022

@Hipska Would you mind providing link(s) to Telegraf's documentation that detail its behavior with regards to delivery guarantees?

Our definition of "delivery guarantees" is that there is support for a source (so let's say... something writing to Telegraf using a request/response protocol) to be told that the event data it sent has been successfully processed by a sink (so wherever Telegraf happens to be sending the data).

Naturally, not all sources/inputs and sinks/outputs use a request/response protocol, so not all configurations will support delivery guarantees, but it wasn't clear from a cursory glance that Telegraf has any sort of delivery guarantee capabilities to begin with.

@Hipska
Copy link
Contributor Author

Hipska commented Dec 14, 2022

Okay, that is indeed not something telegraf is providing. Telegraf can confirm the receiving of a metric to its input/source and is also aware of correct sending a metric to its output/sink, but there is no relation to the complete flow. I will remove that tick then..

As said in #14475, it is unclear when a tool gets a tick, so I'm open for comments.

@Hipska
Copy link
Contributor Author

Hipska commented Dec 14, 2022

@tobz Maybe it should be outlined that the telegraf delivery guarantees are not end-to-end by the means of an icon or footnote?

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska !

@jszwedko jszwedko merged commit 6559102 into vectordotdev:master Jan 6, 2023
@Hipska Hipska deleted the patch-1 branch January 7, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparing Telegraf
4 participants