Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Update VRL to c69a52e67 and mlua to 0.10.0 #21670

Merged
merged 5 commits into from
Oct 31, 2024
Merged

chore(deps): Update VRL to c69a52e67 and mlua to 0.10.0 #21670

merged 5 commits into from
Oct 31, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Oct 31, 2024 •
edited
Loading

These need to be updated together due to breaking changes.

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

n/a

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

References

Closes: #21647

@dependabot @jszwedko
chore(deps): Update VRL to c69a52e67 and mlua to 0.10.0
2201ab3 
These need to be updated together due to breaking changes.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 31, 2024
@jszwedko jszwedko requested a review from a team as a code owner October 31, 2024 19:51
@github-actions github-actions bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label Oct 31, 2024
pront
pront approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the domain: transforms Anything related to Vector's transform components label Oct 31, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 31, 2024
View reviewed changes
src/internal_events/lua.rs Fixed Show resolved Hide resolved
src/internal_events/lua.rs Fixed Show fixed Hide fixed
@jszwedko
regenerate Cargo.lock
95797ae 
Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
spelling
be43edd 
Signed-off-by: Jesse Szwedko <[email protected]>
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/update-vrl-and-mlua
Commit report: 6bc5f2a
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

@jszwedko jszwedko added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit b22b732 Oct 31, 2024
41 checks passed
@jszwedko jszwedko deleted the jszwedko/update-vrl-and-mlua branch October 31, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pront pront pront approved these changes

Assignees
No one assigned
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jszwedko @pront