Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sample transform): component feature check fix #21677

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix(sample transform): component feature check fix #21677

merged 1 commit into from
Nov 1, 2024
+325 −340

Conversation

pront
Copy link
Contributor

@pront pront commented Nov 1, 2024 •
edited
Loading

Summary

Fix broken feature check.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Trigger check.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

References

@pront pront requested a review from a team as a code owner November 1, 2024 15:02
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 1, 2024
@github-actions github-actions bot added the domain: transforms Anything related to Vector's transform components label Nov 1, 2024
@pront pront requested a review from jszwedko November 1, 2024 15:02
pront
pront commented Nov 1, 2024
View reviewed changes
Copy link
Contributor Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-component-features

@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/fix-sample-features
Commit report: 1f3d810
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.45s Total Time

@pront pront added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit 710f224 Nov 1, 2024
79 of 81 checks passed
@pront pront deleted the pront/fix-sample-features branch November 1, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
domain: transforms Anything related to Vector's transform components no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @jszwedko