Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Remove environment stage name #21681

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Nov 1, 2024

Summary

This was flagged by https://docs.docker.com/reference/build-checks/stage-name-casing/ for being uppercase over here: https://github.com/vectordotdev/vector/pull/19683/files, but is also unnecessary since there is only one stage in this Dockerfile.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

CI

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

References

This was flagged by https://docs.docker.com/reference/build-checks/stage-name-casing/ for being
uppercase, but is also unnecessary since there is only one stage in this Dockerfile.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 1, 2024
@jszwedko jszwedko requested a review from a team as a code owner November 1, 2024 21:48
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Nov 1, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/remove-environment-layer-name
Commit report: ecf0389
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.48s Total Time

@jszwedko jszwedko added this pull request to the merge queue Nov 1, 2024
Merged via the queue into master with commit b5de16c Nov 1, 2024
64 checks passed
@jszwedko jszwedko deleted the jszwedko/remove-environment-layer-name branch November 1, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants