Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove 'unset HOMEBREW_NO_INSTALL_FROM_API' line #21787

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

pront
Copy link
Contributor

@pront pront commented Nov 13, 2024

The Homebrew/homebrew-cask#150323 issue was fixed.

@pront pront requested a review from a team as a code owner November 13, 2024 17:45
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Nov 13, 2024
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 13, 2024
Copy link
Contributor Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-unit-mac

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Nov 13, 2024

Datadog Report

Branch report: pront/remove-boostrap-todo
Commit report: 88165f4
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@pront pront added this pull request to the merge queue Nov 13, 2024
@pront pront removed this pull request from the merge queue due to a manual request Nov 13, 2024
Copy link
Contributor Author

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-unit-mac

@pront pront enabled auto-merge November 13, 2024 21:22
@pront pront added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit b32ea2f Nov 14, 2024
41 checks passed
@pront pront deleted the pront/remove-boostrap-todo branch November 14, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants