Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add statuses write permission to workflows #21788

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Nov 13, 2024

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Will need to test after this is merged.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Related:

@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 13, 2024
@jszwedko jszwedko requested a review from a team as a code owner November 13, 2024 18:18
Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@pront pront enabled auto-merge November 13, 2024 18:20
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/add-commit-statuses-to-triggered-workflows
Commit report: f47d500
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.42s Total Time

@pront pront disabled auto-merge November 13, 2024 19:38
@pront pront enabled auto-merge November 13, 2024 19:38
@pront pront disabled auto-merge November 13, 2024 21:11
@pront
Copy link
Contributor

pront commented Nov 13, 2024

Hm, https://github.com/vectordotdev/vector/actions/runs/11823354692. I think it reads the workflow from master?

@pront pront merged commit 9fa3516 into master Nov 13, 2024
49 checks passed
@pront pront deleted the jszwedko/add-commit-statuses-to-triggered-workflows branch November 13, 2024 21:14
@pront
Copy link
Contributor

pront commented Nov 13, 2024

After merging, this was triggered correctly via a review comment: https://github.com/vectordotdev/vector/actions/runs/11825931186/job/32950817911

@jszwedko
Copy link
Member Author

Hm, https://github.com/vectordotdev/vector/actions/runs/11823354692. I think it reads the workflow from master?

Yeah, unfortunately the comment triggers use the workflow file from master making it difficult to test changes like these before they are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants