-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade async-nats and enable FIPS #22543
base: master
Are you sure you want to change the base?
Conversation
b073489
to
1b3a371
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-all
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.5s Total Time |
a431c95
to
5e14b82
Compare
5e14b82
to
5e5321f
Compare
ba26a52
to
80a43ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-all
Summary
Bump the
async-nats
dependency to the latest version and turn on the FIPS backend.Bumping the version is trivial but this PR also updates all environments/runners to include the dependencies necessary to build the FIPS backend. For example, we have to install Go (mega-sad) in our CI because it is a build dependency.
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Checklist
make check-all
is a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References
Ref: #8435