Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more ACs for isolated-margin #2069

Merged
merged 6 commits into from
Nov 28, 2023
Merged

feat: add more ACs for isolated-margin #2069

merged 6 commits into from
Nov 28, 2023

Conversation

Jiajia-Cui
Copy link
Contributor

No description provided.

@Jiajia-Cui Jiajia-Cui self-assigned this Nov 28, 2023
witgaw
witgaw suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@witgaw witgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and questions:

protocol/0019-MCAL-margin_calculator.md Outdated Show resolved Hide resolved
protocol/0019-MCAL-margin_calculator.md Outdated Show resolved Hide resolved
protocol/0019-MCAL-margin_calculator.md Outdated Show resolved Hide resolved
protocol/0019-MCAL-margin_calculator.md Outdated Show resolved Hide resolved
protocol/0019-MCAL-margin_calculator.md Outdated Show resolved Hide resolved
protocol/0019-MCAL-margin_calculator.md Outdated Show resolved Hide resolved
@Jiajia-Cui Jiajia-Cui merged commit d31d380 into palazzo Nov 28, 2023
4 checks passed
@Jiajia-Cui Jiajia-Cui deleted the more-ac-isolated-margin branch November 28, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witgaw witgaw witgaw approved these changes

Assignees

@Jiajia-Cui Jiajia-Cui

Labels
spec-improvement
Projects
Core Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiajia-Cui @witgaw