Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for attachments in Svelte useChat #3032

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tyfiero
Copy link

@tyfiero tyfiero commented Sep 16, 2024

Made a fix for attachments to work with Svelte. Took me longer than I'd like to admit to find out how to fix this. Works well for us

@cs50victor
Copy link

cs50victor commented Sep 16, 2024

🚀. this was a very tricky bug to figure out. @lgrammel @MaxLeiter

@lgrammel
Copy link
Collaborator

cc @jeremyphilemon - was this already implemented or would the solution be more involved (with file lists etc)? I don't want Svelte to have deviate from what we implemented in React

@tyfiero
Copy link
Author

tyfiero commented Sep 17, 2024

cc @jeremyphilemon - was this already implemented or would the solution be more involved (with file lists etc)? I don't want Svelte to have deviate from what we implemented in React

Well this does work with multiple files in experimental_attachments we've tested it, its essentially the same code from the react package, I just added the two lines that were missing in svelte.

@lgrammel
Copy link
Collaborator

@tyfiero
Copy link
Author

tyfiero commented Oct 3, 2024

We opted to port our app over to react from svelte. It's clear the svelte package doesn't have, and will never have, the same support that the react package will. I won't have the time to implement those other attachment features in svelte. This PR can be closed.

@MentalGear
Copy link

I think feature parity should be an overall goal, no matter the front end library - especially for svelte that is officially supported by vercel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants