Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a few remaning global variables from the placement stage #2872

Merged
merged 10 commits into from
Jan 28, 2025
Merged

Remove a few remaning global variables from the placement stage #2872

merged 10 commits into from
Jan 28, 2025

Conversation

soheilshahrouz
Copy link
Contributor

When running multiple annealer in parallel, I found a few global variables left from previous refactorings. This PR moves them to BlkLocRegistry.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code libvtrutil labels Jan 27, 2025
vaughnbetz
vaughnbetz reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few commenting minor typos etc.

libs/libvtrutil/src/vtr_log.h Outdated Show resolved Hide resolved
vpr/src/base/blk_loc_registry.h Outdated Show resolved Hide resolved
AlexandreSinger
AlexandreSinger approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreSinger AlexandreSinger merged commit b4f358a into master Jan 28, 2025
36 checks passed
@AlexandreSinger AlexandreSinger deleted the temp_some_cleanups branch January 28, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz left review comments

@AlexandreSinger AlexandreSinger AlexandreSinger approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code libvtrutil VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soheilshahrouz @vaughnbetz @AlexandreSinger