Add initial nightly test workflow #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @AmirhosseinPoolad Thank you for raising this PR! I had a small comment on the GCC version. Its best just to fix this now, so we are testing on the correct version!
Other than that, LGTM
|
|
||
| env: | ||
| # default compiler for all non-compatibility tests | ||
| MATRIX_EVAL: "CC=gcc-11 && CXX=g++-11" |
There was a problem hiding this comment.
I think this needs to be GCC 13. This was a leftover before I upgraded the CI to Ubuntu 24.04.
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the new nightly test workflow to the list of workflows. Unfortunately to test GitHub actions workflows there has to be a version of it in the master branch, but after this PR is merged we can debug and resolve any issues in the "savi_nightly_test" branch so thankfully we don't have to test on master. This workflow can only be manually dispatched so there shouldn't be any automatic runs that could overwhelm the SAVI machines while we're working on the workflow and fixing any potential issues.