Fix #68 not working with static plugin #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalGoslawski
commented
Nov 21, 2024
| @@ -138,7 +134,7 @@ export const compression = ( | |||
|
|
|||
| contentType = resContentType ? resContentType : 'text/plain' | |||
|
|
|||
| const buffer = await res.arrayBuffer() | |||
| const buffer = await res.clone().arrayBuffer() | |||
There was a problem hiding this comment.
This is the actual fix. The other changes are tests and minor cleanup of issues found by my IDE.
RafalGoslawski
commented
Nov 21, 2024
| expect(res.headers.get('Content-Type')).toBe('image/png') | ||
| expect(res.headers.get('vary')).toBeNull() | ||
|
|
||
| const actualBody = await res.arrayBuffer() |
There was a problem hiding this comment.
Without the fix, the error here is:
132 | const actualBody = await res.arrayBuffer()
^
error: Body already used
code: "ERR_BODY_ALREADY_USED"
|
As a temporary workaround, here is a branch with this PR, with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed fix for #68
After investigation it turned out that in some cases the response body is consumed by the plugin and not replaced with a correct response. Using 'res.clone()' when getting the response buffer prevents breaking the original response if we exit early with
return