Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] account_statement_import_camt: Migration to 18.0 #3

Merged
merged 29 commits into from
Feb 6, 2025

Conversation

psugne
Copy link

@psugne psugne commented Feb 5, 2025

Inspiration from OCA PR

i-vyshnevska and others added 28 commits February 5, 2025 18:09
Currently translated at 75.0% (9 of 12 strings)

Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_camt/nl/
Currently translated at 83.3% (10 of 12 strings)

Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_camt/it/
Encountered in a Camt.054 statement: currency listed under
/BkToCstmrDbtCdtNtfctn/Ntfctn/Ntry/Amt/@ccy
with this commit, the narration field is filled with infos find in the camt file such as reversal indicator, return reason, cheque number, ...
before only a banking ref was present.

The transaction type field is also filled.
Currently translated at 100.0% (12 of 12 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/
Currently translated at 100.0% (31 of 31 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/es/
Currently translated at 22.5% (7 of 31 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/it/
This refactoring will allow using `TestParser._do_parse_test()` method for subclasses defined in inheriting modules.

This way, if the new module defines new files in other paths than `account_statement_import_camt/test_files/`,
 subclasses of `TestParser` will still be able to use the `_do_parse_test()` method for imports and checks.

Moreover, a custom value can now be defined for the acceptable differing lines number between inputfile and goldenfile.

It will also maintain backward compatibility with the current usage of the method
 (ie: using only a filename with the assumption of finding it in `account_statement_import_camt/test_files/`).

NB: methods are now defined outside of `TestParser` to allow importing them directly, instead of inheriting from `TestParser`.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_camt/
Currently translated at 100.0% (29 of 29 strings)

Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_camt/it/
@psugne psugne requested a review from dangirasv February 5, 2025 16:28
@versada versada deleted a comment from dangirasv Feb 6, 2025
@psugne psugne merged commit ba12420 into 18.0-versada Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.