fix objectId encoding/decoding on json objects #90
Conversation
Signed-off-by: Rémy NOËL <[email protected]>
Signed-off-by: Rémy NOËL <[email protected]>
|
@llfbandit Pretty happy with this one as well although anything that touches ids make me nervous. I'm wondering if further tests can be added around any edge cases here. |
|
Yup, I understand, I've added only 1 test but is actually processed 3 times especially with one default behaviour and one with MongoClientWithObjectIdTest which add the property useObjectId. |
|
A further though about the use of useObjectId and its automatic behaviour is for nested objects, there's no recurrence made on objects (un-)wrap them. |
|
Again slight conflict, but happy to merge when fixed. Thanks again for the contribution |
Signed-off-by: Rémy NOËL <[email protected]>
|
@llfbandit Couple of small conflicts left |
Signed-off-by: Rémy NOËL <[email protected]>
Signed-off-by: Rémy NOËL <[email protected]>
Signed-off-by: Rémy NOËL <[email protected]> (reverted from commit 55c8860)
…objectId_encoding # Conflicts: # vertx-mongo-client/src/main/asciidoc/dataobjects.adoc # vertx-mongo-client/src/main/java/io/vertx/ext/mongo/impl/MongoClientImpl.java
| @@ -279,7 +279,7 @@ mongoClient.update("books", query, update, { res -> | |||
| ---- | |||
|
|
|||
| To specify if the update should upsert or update multiple documents, use `link:../../groovydoc/io/vertx/groovy/ext/mongo/MongoClient.html#updateWithOptions(java.lang.String,%20io.vertx.core.json.JsonObject,%20io.vertx.core.json.JsonObject,%20io.vertx.ext.mongo.UpdateOptions,%20io.vertx.core.Handler)[updateWithOptions]` | |||
| and pass in an instance of `link:../dataobjects.html#UpdateOptions[UpdateOptions]`. | |||
| and pass in an instance of `link:../../null/dataobjects.html#UpdateOptions[UpdateOptions]`. | |||
|
|
|||
There was a problem hiding this comment.
groovy doc generation bug ? how does it look like with other languages ?
Check that ObjectId convertion is applied to all objects that it should apply to #45