Unify error message structure in EventBusBridge #2701
+82
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The message structure should be consistent to all error messages in
EventBusBridge
. The following is a list of a consistent error types with descriptive messages:The
failureCode
for the above is-1
and all types with messages are tested except forSOCKET_EXCEPTION
which I didn't find any unit test for such a use case so I added generic descriptive message in case theThrowable#getMessage()
isnull
.Finally, this PR addresses inconsistency of all error messages in
EventBusBridge
#2693Thanks!