Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Fuzzy items in SameElement correctly #33300

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Handle Fuzzy items in SameElement correctly #33300

merged 2 commits into from
Feb 12, 2025

Conversation

bratseth
Copy link
Member

No description provided.

@bratseth bratseth requested a review from vekterli February 11, 2025 15:54
vekterli
vekterli approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@vekterli vekterli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 had to test this locally first to ensure the backend doesn't implode when receiving a sameElement + fuzzy combo. Looks like it works out of the box with indexed mode, but doesn't work with streaming mode.

@bratseth bratseth merged commit 02c9b5d into master Feb 12, 2025
3 checks passed
@bratseth bratseth deleted the bratseth/fuzzy-in-sameElement branch February 12, 2025 13:23
@vekterli vekterli mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vekterli vekterli vekterli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bratseth @vekterli