New Long Read Giraffe parameters #4524
Merged
+195
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add limit for read length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg giraffehas newhifiandr10preset parameters that improve speed, are mostly neutral on calling accuracy, but add more wrong MAPQ 60 HiFi reads.vg giraffe: all minimizer and zipcode files will need to be re-generated to take advantage of it.Description
This changes the Long Read Giraffe parameters to increase speed, balance performance across the sampled and non-sampled graphs, and (sadly) add a bunch of to-be-diagnosed wrong MAPQ 60 HiFi reads.
It also has @xchang1's fix for a problem with zip code tree orientations.