Remove VisitWithExplicitNoDfDx and replace it with plain Visit. #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the reverse mode, ``VisitWithExplicitNoDfDx(const Stmt* S)`` visits ``S`` while pushing ``nullptr`` to the ``dfdx()`` stack. This is exactly the behaviour we get when calling ``Visit(const Stmt* S, Expr* dfdS = nullptr)`` with a single parameter. In other words, ``VisitWithExplicitNoDfDx(S)`` is the same as ``Visit(S)``. This PR removes this function.
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1226 +/- ##
==========================================
- Coverage 94.60% 94.59% -0.01%
==========================================
Files 51 51
Lines 8929 8924 -5
==========================================
- Hits 8447 8442 -5
Misses 482 482
|
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the reverse mode,
VisitWithExplicitNoDfDx(const Stmt* S)visitsSwhile pushingnullptrto thedfdx()stack. This is exactly the behaviour we get when callingVisit(const Stmt* S, Expr* dfdS = nullptr)with a single parameter. In other words,VisitWithExplicitNoDfDx(S)is the same asVisit(S). This PR removes this function.