Remove m_DerivativeForForwSweep from StmtDiff #1230
Merged
+27
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
- Coverage 94.65% 94.65% -0.01%
==========================================
Files 51 51
Lines 8908 8901 -7
==========================================
- Hits 8432 8425 -7
Misses 476 476
|
|
Can you rebase? |
Currently, ``m_DerivativeForForwSweep`` is used to store adjoint to the reference to a given expression. e.g. 1) for ``x``, it stores ``_d_x`` 2) for ``x[i]``, ``_d_x[i]`` etc. We only use ``m_DerivativeForForwSweep`` to initialize reference-type variables. However, to initialize pointers, we use ``getExpr_dx()``. Pointers and references are equivalent and should be initialized the same way. When differentiating expressions, we initialize ``m_DerivativeForForwSweep`` either with the same value as ``Expr_dx`` or with ``nullptr``.
PetroZarytskyi
force-pushed
the
remove-forw
branch
from
b0f28ee to
ffa0102
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1228.
Currently,
m_DerivativeForForwSweepis used to store adjoint to the reference to a given expression. e.g.x, it stores_d_xx[i],_d_x[i]etc.
We only use
m_DerivativeForForwSweepto initialize reference-type variables. However, to initialize pointers, we usegetExpr_dx(). Pointers and references are equivalent and should be initialized the same way. When differentiating expressions, we initializem_DerivativeForForwSweepeither with the same value asExpr_dxor withnullptr.