Enable llvm19, remove llvm8 support. #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -126,7 +126,7 @@ namespace utils { | |||
| DECLARE_CLONE_FN(SubstNonTypeTemplateParmExpr) | |||
| DECLARE_CLONE_FN(CXXScalarValueInitExpr) | |||
| DECLARE_CLONE_FN(ConstantExpr) | |||
| CLAD_COMPAT_8_DECLARE_CLONE_FN(ValueStmt) | |||
| DECLARE_CLONE_FN(ValueStmt) | |||
There was a problem hiding this comment.
warning: no header providing "clang::ValueStmt" is directly included [misc-include-cleaner]
DECLARE_CLONE_FN(ValueStmt)
^| CLAD_COMPAT_ExprValueKind_R_or_PR_Value, | ||
| ExprObjectKind::OK_Ordinary CLAD_COMPAT_CLANG9_MemberExpr_ExtraParams( | ||
| NOUR_None)); | ||
| CLAD_COMPAT_ExprValueKind_R_or_PR_Value, ExprObjectKind::OK_Ordinary, |
There was a problem hiding this comment.
warning: no header providing "clang::ExprObjectKind" is directly included [misc-include-cleaner]
CLAD_COMPAT_ExprValueKind_R_or_PR_Value, ExprObjectKind::OK_Ordinary,
^| ExprObjectKind::OK_Ordinary CLAD_COMPAT_CLANG9_MemberExpr_ExtraParams( | ||
| NOUR_None)); | ||
| CLAD_COMPAT_ExprValueKind_R_or_PR_Value, ExprObjectKind::OK_Ordinary, | ||
| NOUR_None); |
There was a problem hiding this comment.
warning: no header providing "clang::NOUR_None" is directly included [misc-include-cleaner]
NOUR_None);
^| DAP, FD->getNameInfo(), | ||
| /*TemplateArgs=*/nullptr, m_Context.BoundMemberTy, | ||
| CLAD_COMPAT_ExprValueKind_R_or_PR_Value, | ||
| ExprObjectKind::OK_Ordinary, NOUR_None); |
There was a problem hiding this comment.
warning: no header providing "clang::ExprObjectKind" is directly included [misc-include-cleaner]
ExprObjectKind::OK_Ordinary, NOUR_None);
^| DAP, FD->getNameInfo(), | ||
| /*TemplateArgs=*/nullptr, m_Context.BoundMemberTy, | ||
| CLAD_COMPAT_ExprValueKind_R_or_PR_Value, | ||
| ExprObjectKind::OK_Ordinary, NOUR_None); |
There was a problem hiding this comment.
warning: no header providing "clang::NOUR_None" is directly included [misc-include-cleaner]
ExprObjectKind::OK_Ordinary, NOUR_None);
^| @@ -739,7 +739,11 @@ | |||
| // FIXME: currently this doesn't print func<templates>(args...) while | |||
| // dumping and only prints func(args...), we need to fix this. | |||
| auto* FTD = dyn_cast<FunctionTemplateDecl>(R.getRepresentativeDecl()); | |||
| #if CLANG_VERSION_MAJOR < 19 | |||
There was a problem hiding this comment.
warning: no header providing "CLANG_VERSION_MAJOR" is directly included [misc-include-cleaner]
lib/Differentiator/VisitorBase.cpp:32:
- #include <numeric>
+ #include <clang/Basic/Version.h>
+ #include <numeric>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
- Coverage 94.65% 94.64% -0.01%
==========================================
Files 51 51
Lines 8901 8890 -11
==========================================
- Hits 8425 8414 -11
Misses 476 476
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112.