Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Xcode 16 as onReturn function name is conflict with Xcode by default function name #66

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for Xcode 16 as onReturn function name is conflict with Xcode by default function name #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce8c0f1
Change the "onReturn" function name to the "onReturnKeyPress" to avoi…
KrishnaM0618 Oct 29, 2024
f063984
Update Closures.podspec.json
KrishnaM0618 Oct 29, 2024
bc7c481
Update project.pbxproj
KrishnaM0618 Nov 13, 2024
9a682b0
Update Core.swift
KrishnaM0618 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Supporting/cocoapods/Closures.podspec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Closures",
"version": "0.7",
"summary": "Swifty closures for UIKit and Foundation",
"homepage": "https://github.com/vhesener/Closures",
"homepage": "https://github.com/KrishnaM0618/Closures",
"screenshots": [
"https://raw.githubusercontent.com/vhesener/Closures/assets/assets/playground_general.gif",
"https://raw.githubusercontent.com/vhesener/Closures/assets/assets/reference_large.png"
Expand All @@ -13,7 +13,7 @@
"ios": "9.0"
},
"source": {
"git": "https://github.com/vhesener/Closures.git",
"git": "https://github.com/KrishnaM0618/Closures.git",
"tag": "v0.7"
},
"source_files": "Xcode/Closures/Source",
Expand Down
4 changes: 2 additions & 2 deletions Xcode/Closures.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Closures/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.vhesener.Closures;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -457,7 +457,7 @@
DYLIB_INSTALL_NAME_BASE = "@rpath";
INFOPLIST_FILE = Closures/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.vhesener.Closures;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
4 changes: 2 additions & 2 deletions Xcode/Closures/Source/Core.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@

import Foundation

protocol DelegateProtocol: class {
protocol DelegateProtocol: AnyObject {
}

@available(iOS 9.0, *)
public protocol DelegatorProtocol: class {
public protocol DelegatorProtocol: AnyObject {
/**
Clears any delegates/datasources that were assigned by the `Closures`
framework for this object. This cleans up memory as well as sets the
Expand Down
2 changes: 1 addition & 1 deletion Xcode/Closures/Source/UIControl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ extension UITextField {
* returns: itself so you can daisy chain the other event handler calls
*/
@discardableResult
public func onReturn(handler: @escaping () -> Void) -> Self {
public func onReturnKeyPress(handler: @escaping () -> Void) -> Self {
on(.editingDidEndOnExit) { _,_ in
handler()
}
Expand Down