Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when extract multiple adjacent words from a string without word boundaries #142

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lishukan
Copy link

Dear developers:
There is no doubt that flashtext is an excellent string matching tool. I have already used it on a large number of occasions. But recently I found it in a string without word boundaries (such as a Chinese sentence),

If two words that need to be extracted happen to be adjacent, then it will only be able to extract the first word.

So I made some modifications: when matching words, the index for the next iteration will start at the end of the last matched word.

I have added a new use case and It passed all unit tests.

image

@abulice
Copy link

abulice commented Sep 21, 2023 via email

@lishukan
Copy link
Author

@vi3k6i5 Hello, dear owner . Is this repo still maintained ? I found that this repo hasn't updated its code for a long time . If it is no longer maintained, I will no longer wait for the merge of the MR.

lishukan and others added 2 commits October 23, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants