Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code samples more consistent #771

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Make code samples more consistent #771

merged 2 commits into from
Nov 1, 2024

Conversation

npentrel
Copy link
Contributor

No description provided.

@npentrel npentrel requested a review from a team as a code owner October 23, 2024 12:19
@github-actions GitHub Actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_properties
mlmodel metadata
slam get_point_cloud_map

njooma
njooma reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the input names are inconsistent -- you have machine, robot, and myRobotWithController. Should they all just be machine?

stuqdog
stuqdog approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo naveed's comment.

@npentrel
Copy link
Contributor Author

npentrel commented Nov 1, 2024

Good catch - thanks

@npentrel npentrel merged commit f5c2676 into main Nov 1, 2024
12 checks passed
@npentrel npentrel deleted the consistency branch November 1, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma left review comments

@stuqdog stuqdog stuqdog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npentrel @njooma @stuqdog