Avoid rebuilding models for ListQuantityGroup and ListTextGroup #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blammit
requested review from
chriadam,
DanielMcInnes and
MikeTrahearn-Qinetic
QuantityObject provides QObject-based access to a quantity value. QuantityObjectModel provides a model of QuantityObject values, and is able to filter out items that do not have valid values. This allows ListQuantityGroup and its derived types to specify their models without creating a JavaScript array that directly refers each quantity value. Otherwise, whenever a quantity value is updated, the entire array is rebuilt, which in turn causes the QuantityRow repeater to rebuild its delegates. Part of #1338
blammit
force-pushed
the
blam/1338-avoid-rebuilding-models-for-listquantitygroup-and-listtextgroup
branch
from
0f77dbd to
fd51a61
Compare
pages/settings/PageCanbusStatus.qml
Outdated
| id: busOffCounters | ||
| } | ||
| content.children: [ | ||
| ColumnLayout { |
There was a problem hiding this comment.
You don't normally reach for a layout - did you mean to use ColumnLayout deliberately over Column? Same below.
There was a problem hiding this comment.
Thanks, the ColumnLayout was from WIP code so I've reverted it to a Column, as there aren't any particular benefits here from using the layout.
|
|
||
| int main(int argc, char **argv) \ | ||
| { | ||
| qmlRegisterType<Victron::VenusOS::QuantityObject>("Victron.VenusOS", 2, 0, "QuantityObject"); |
There was a problem hiding this comment.
These (and in other tests) would not be needed if the test executable was correctly linked to the module.
There was a problem hiding this comment.
Yes, it would be worth cleaning that up, as a separate task
| import Victron.VenusOS | ||
| import QtQuick.Window | ||
|
|
||
| TestCase { |
There was a problem hiding this comment.
does the test cover the append/remove cases or are they not applicable because of the usage of QQmlListProperty?
There was a problem hiding this comment.
Yes, not applicable as you said. We can have add/remove support in QuantityObjectModel in the future if needed.
Change QuantityRow's model type to QuantityObjectModel, so that the model cannot be specified as an array of real values, and update the codebase accordingly so that it always uses QuantityObject with QuantityObjectModel instead of an array-based model in all cases where multiple quantities are displayed. This greatly improves the performance of QuantityRow in updating its values, as the Repeater no longer rebuilds its delegates whenever a single quantity changes in the model. Also, since QuantityObjectModel is able to filter out invalid values, it is not necessary to create and show separate models depending on whether particular values are valid. The updates affect the following types and their uses: - QuantityRow - ListQuantityGroup - ListQuantityGroupNavigation Also remove ListTextGroup and replace its uses with ListQuantityGroup, as ListTextGroup was being used to show text alongside number values, and that can now easily be done with ListQuantityGroup as a QuantityObject value can be a string if the unit is Units_None. Part of #1338
blammit
force-pushed
the
blam/1338-avoid-rebuilding-models-for-listquantitygroup-and-listtextgroup
branch
from
fd51a61 to
777b93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.