Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min and max zoom level options for markers #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gsterndale
Copy link
Contributor

Hi!

I found some odd marker behavior when they were created outside the MarkerManger's maxZoom.

This commit provides settings options for min and max marker zoom levels with reasonable defaults.

I'm not too familiar with Smoke and couldn't find a way to set an expectation that the MarkerManager constructor is called with the maxZoom option. Perhaps you know how???

Thanks for all the hard work!
Greg

@brianjlandau
Copy link
Contributor

Can you show me an example page of the problem you're seeing?

@gsterndale
Copy link
Contributor Author

Hi Brian!

I just rebased these commits on top of recent (related) upstream work.

If you look at one of these example pages and zoom way out, the markers disappear. I found that if the map is loaded at a zoom level outside the normal visible range, the markers appear initially, but after zooming in then back out, they'd disappear.

My commits should allow developers to define what zoom level range they prefer for their markers.

Let me know what you think.

Best,
Greg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants