OpenHashMaps.mergePRIMITIVE: Avoid double-hashing key #337
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#if VALUES_PRIMITIVE && ! VALUE_CLASS_Booleancomes from the superclass in Map.drv:fastutil/drv/Map.drv
Line 649 in 355d8eb
The implementation mostly is copied from the method below (
merge), with dead code removed becauseVALUES_PRIMITIVEis always true.I'm using the
METHOD_ARG_VALUE_BINARY_OPERATORso that we prefer using the JDK ${Primitive}BinaryOperator classes, and fall back to the fastutil primitive-BinaryOperators where not present in the JDK.I ran the junit tests locally and they pass.
Towards #336