Fix #378: Add blockhash parameter into gettxproof command #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
requested changes
Feb 18, 2025
| ) -> Result<Vec<String>, RpcError> { | ||
| if let Some(hash) = block_hash { | ||
| let block = self.get_block(hash).await?; | ||
| return Ok(vec![block |
There was a problem hiding this comment.
This returns the transaction, not the merkle proof for it as this method should
| @@ -297,8 +297,15 @@ async fn handle_json_rpc_request(req: Value, state: Arc<RpcImpl>) -> Result<serd | |||
| "gettxoutproof" => { | |||
| let txid = Txid::from_str(params[0].as_str().ok_or(Error::InvalidHash)?) | |||
| .map_err(|_| Error::InvalidHash)?; | |||
| let blockhash = match params[1].as_str() { | |||
There was a problem hiding this comment.
It is easier to try parse and return error if it fails, like we do with txid
TheMhv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fix the issue #378
Which crates are being modified?
Description
Add missing
block_hashparameter intoget_tx_prooffunction and check if transaction is included in the block.