RFC: Switching to custom parser for binary. #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larrydewey
commented
Feb 13, 2025
larrydewey
commented
- Refactoring some misplaced code
- Adding custom parsing functionality
- Implemented new and updated existing unit tests to match new functionality
- Implemented parsing library in place of bincode where possible (eventually will completely remove it)
larrydewey
force-pushed
the
nom-parser
branch
12 times, most recently
from
58e55a8 to
04148cf
Compare
larrydewey
requested review from
tylerfanelli and
DGonzalezVillal
as code owners
larrydewey
force-pushed
the
nom-parser
branch
2 times, most recently
from
9e0cac5 to
a12990b
Compare
|
What exactly was wrong with the original binary parsing done? This introduces a few breaking changes that will require a major update. |
|
Bincode does not do an actual binary deserialization of bytes. It uses a custom format. Serde also relies on binary metadata to determine which instance of an enum something might be. This implementation removes the dependency on bincode to identify attestation report information. It will be a fairly trivial change to adapt this work to the versioning issue, as well. Yes, this will definitely introduce a significant breaking change, but it will align us with a path moving forward for various version change needs. |
larrydewey
force-pushed
the
nom-parser
branch
2 times, most recently
from
bf13599 to
62fbce5
Compare
- Refactoring some misplaced code - Adding custom parsing functionality - Implemented new and updated existing unit tests to match new functionality - Implemented parsing library in place of bincode where possible (eventually will completely remove it) - Added clippy fixes - Updated README.md Signed-off-by: Larry Dewey <[email protected]>
larrydewey
force-pushed
the
nom-parser
branch
from
62fbce5 to
afd8d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.