-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Basic fixes and extentions to build scripting #1231
Merged
YanVugenfirer
merged 1 commit into
virtio-win:master
from
benyamin-codez:build-ex-basics
Jan 20, 2025
Merged
[build] Basic fixes and extentions to build scripting #1231
YanVugenfirer
merged 1 commit into
virtio-win:master
from
benyamin-codez:build-ex-basics
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2025
kostyanf14
reviewed
Jan 8, 2025
Just concerns re |
@benyamin-codez Please squash all commits and force push this PR |
1. Fixed various syntax issues, including an unquoted variable in conditional test (Debug or Release log file name), superfluous backslashes, spaces between errorlevel tests and tested functions, MSBuild syntax consolidaiton, prefixing FOR do commands with @, etc. 2. Unwrapped nested IF statements to ensure no jumping out of loops or other unexpected behaviours. 3. Updated usage, including Win11 target and explanation regarding analysis builds (build.bat only). 4. Added analysis build specific variables CODEQL_FAILED and SDV_FAILED to init area (build.bat only). 5. Refactored fail code, removing return failure detection in favour of in-line failure detection. 6. Updated labels to use snake style notation. 7. Refactored end of build_arch function to avoide "goto :eof" and instead use ":build_arch_done" to ensure POPD occurs and ":build_arch_skip" to check for success before ending the local environment (build.bat only). 8. Do conditional (if exists) removal of sdv and codeql_db folders (build.bat only). 9. Additional commenting and stdout output (logging). 10. Remove superfluous newline spacing. 11. Removed packaging folder from build per PRs virtio-win#1209 and virtio-win#1224 (buildAll.bat only). 12. Consolidated exiting function (whether success or fail) to :leave (buildAll.bat only). Split from PR virtio-win#1212. Signed-off-by: benyamin-codez <[email protected]>
benyamin-codez
force-pushed
the
build-ex-basics
branch
from
January 18, 2025 10:59
7fe7d21
to
2273327
Compare
YanVugenfirer
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side.
kostyanf14
approved these changes
Jan 20, 2025
YanVugenfirer
approved these changes
Jan 20, 2025
@benyamin-codez Thanks a lot! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from PR #1212.