Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TripResolver.ts #16

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Update TripResolver.ts #16

merged 1 commit into from
Oct 7, 2024

Conversation

Aryam2121
Copy link
Contributor

API Call to Google Maps: We are making an API call to the Google Maps Directions API to get the route information, including traffic data (duration_in_traffic).

Handling Real-Time Traffic: The API request includes departure_time=now and traffic_model=best_guess to ensure real-time traffic data is considered.

Save Traffic Data in Trip: You might need to update your Trip entity to include fields such as trafficDuration and distance. Here’s how to adjust the Trip entity:

All Submissions:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

API Call to Google Maps: We are making an API call to the Google Maps Directions API to get the route information, including traffic data (duration_in_traffic).

Handling Real-Time Traffic: The API request includes departure_time=now and traffic_model=best_guess to ensure real-time traffic data is considered.

Save Traffic Data in Trip: You might need to update your Trip entity to include fields such as trafficDuration and distance. Here’s how to adjust the Trip entity:
@visheshrwl visheshrwl merged commit 700f0a7 into visheshrwl:main Oct 7, 2024
1 check passed
@visheshrwl
Copy link
Owner

@Aryam2121 amazing work.
Consider starring the repo and hoping for more PR's from your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants