Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize dockerfiles docker-compose #58

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

haseebzaki-07
Copy link
Contributor

@haseebzaki-07 haseebzaki-07 commented Oct 22, 2024

All Submissions:

fixes #56

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

After these steps, you're ready to open a pull request.

a. Optimizes docker setup
b. Additions in dockerfiles and docker-compose, built  a network for all the sevices to talk to each other, fixed reditClient Intialization as it had error from outdated syntax.

c. fixes #56 

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and welcome! 😊
Thank you for submitting your first pull request! Your contributions help us grow and improve this project. We're excited to review your changes. If you need any help or guidance, feel free to reach out. Let's build something amazing together! 🌟

@visheshrwl visheshrwl merged commit fb781f8 into visheshrwl:main Oct 22, 2024
1 of 2 checks passed
@haseebzaki-07
Copy link
Contributor Author

hey @visheshrwl please add the gssoc-ext and level tags

@haseebzaki-07
Copy link
Contributor Author

haseebzaki-07 commented Oct 27, 2024

@visheshrwl level please??

@visheshrwl
Copy link
Owner

Hey @haseebzaki-07 ! 👋

First off, I want to extend a huge thank you to all of you for your amazing contributions to this project! Your support and hard work mean a lot, and I truly appreciate everything you do. 🙏

I have a small favor to ask: if you think I’ve been helpful and supportive throughout your contributions, I would be honored if you could nominate me by filling out this form: Nominate me.

Your nomination would mean the world to me, and it’s a great way to help me continue supporting our awesome community. Thanks again for all the amazing work, and let's keep making great things happen! 🚀

Best,
Vishesh

@haseebzaki-07
Copy link
Contributor Author

Sure @visheshrwl It was really amazing experience for me working with you.

Will definitely nominate you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerize the Application
2 participants