Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix determination of the promiscuity counter for links
Function `LinkDeserialize` checked for presence of `IFF_PROMISC` in the link's flags to determine whether it was in promiscuous mode. This flag only tracks what is set with commands such as ip set <link> promisc on but is not set when you run `tcpdump` or `wireshark` for example, which also put the device in promiscuous mode. There is a counter that tracks the number of times promiscuous mode has been requested. It reacts to all the ways, `ip set`, and also `tcpdump` and co. With this change this counter is used instead of checking the flag. This makes the library reflect what ip -d link show <link> would show in its `promiscuity` field. To test this change, start some processes of `tcpdump` or similar and see the counter increase in `ip -d link show <link>` as well as in the patched version of this netlink library. With the unpatched version the counter remains 0. Then enable promiscuous mode globally for the interface. This will increase the count in all variants, `ip link`, the old unpatched and the patched version of this netlink library. Simple test program for reference: package main import "fmt" import "github.com/vishvananda/netlink" func main() { handle, _ := netlink.NewHandle() links, _ := handle.LinkList() for _, link := range links { attrs := link.Attrs() fmt.Printf("dev=%v promisc=%v\n", attrs.Name, attrs.Promisc) } }
- Loading branch information