Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator plugin function #20231

Open
wants to merge 4 commits into
base: task/biagas/cmake_modernization_with_blt
Choose a base branch
from

Conversation

biagas
Copy link
Contributor

@biagas biagas commented Feb 12, 2025

Description

Adds a visit_add_operator_plugin function for xml2cmake. Similar tovisit_add_plot_plugin.
All the operators' CMakeLists.txt were converted via xml2cmake.
Some operators had changes to their .xml files and/or code files.
Fixed an issue with Volume plot auto-generation of CMakeLists.txt
Fixed a few places that needed #include <visit-config.h>

Type of change

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Documentation update
  • Other
    CMake modernization effort.

How Has This Been Tested?

Compiles cleanly on Windows/Linux. Test suite runs successfully (except plugins-vs-install which will be corrected in a later PR).

Checklist:

  • I have commented my code where applicable.
  • [ ] I have updated the release notes.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have confirmed new and existing unit tests pass locally with my changes.
  • [ ] I have added new baselines for any new tests to the repo.
  • [ ] I have NOT made any changes to protocol or public interfaces in an RC branch.

Update GenerateCMake, run on operators to update CMakeLists.txt.
Rerun xml2cmake on all operators.
Fix Volume plot .code file and re-run xml2cmake.
…r plugin logic.

Rerun xml2cmake for VolumePlot to get updates to includes.
Fix compilation for visitpy/mpicom.
Copy link
Member

@JustinPrivitera JustinPrivitera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love to see code cleanup/refactoring. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants