Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish enhancing build_visit to build on Crossroads. #20232

Open
wants to merge 12 commits into
base: 3.4RC
Choose a base branch
from

Conversation

brugger1
Copy link
Collaborator

Description

Resolves #20120

I made several enhancements to build_visit to build VisIt on Crossroads. These include:

  • I disabled wayland support when building xkbcommon. Crossroads didn't have the wayland support fully installed and we didn't need it.
  • I added the xorg-macros for building xcb, since they were missing on Crossroads.
  • I fixed a bug setting PKG_CONFIG_PATH in bv_xcb.sh.

While I was updating packages in build_visit I also made a few other improvements.

  • I corrected the dependencies for ninja, meson, xkbcommon, and xcb.
  • I moved the location of xcb in a couple of lists in modules.xml so that it was in the correct location alphabetically.

I also made a few other changes as well.

  • I updated the Crossroads config site file.
  • I fixed a compilation bug with the intel compilers with ddtsim.cpp.

I didn't update the release notes since 3.4.2 was already released. I will add it to the 3.5.0 release notes.

Type of change

  • New feature~~

How Has This Been Tested?

I built a unified build_visit and used it to build the VisIt 3.4.2 on Crossroads. I used:

env C_COMPILER=gcc CXX_COMPILER=g++ \
    PAR_COMPILER=mpicc PAR_COMPILER_CXX=mpic++ \
./build_visit3_4_2 --required --optional --parallel --mesagl --ninja --meson --xkbcommon --xcb --qt6 --qwt --no-pyside --no-adios --no-gdal --no-icet --no-visit --makeflags -j12

I then built a second time using C_COMPILER=cc CXX_COMPILER=CC without --no-icet to build IceT.

I then built and installed VisIt in public on Crossroads and was able to run on a login node in serial and client/server in serial and parallel with a single node from Magma. There is still an issue running with more than 1 node in parallel.

Reminders:

  • Please follow the style guidelines of this project.
  • Please perform a self-review of your code before submitting a PR and asking others to review it.
  • Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

  • I have commented my code where applicable.~~
  • [ ] I have updated the release notes.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added debugging support to my changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have confirmed new and existing unit tests pass locally with my changes.
  • [ ] I have added new baselines for any new tests to the repo.
  • I have NOT made any changes to protocol or public interfaces in an RC branch.~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants