Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Go 1.24.0 #17790

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update to Go 1.24.0 #17790

wants to merge 3 commits into from
+29 −26

Conversation

dbussink
Copy link
Contributor

Updates to the latest Go version so that we have this in place before the Vitess 22 release.

@frouioui Could you push the new Docker base images for this?

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink
Update to Go 1.24.0
d466bcf 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink added Component: Build/CI dependencies Pull requests that update a dependency file Type: Dependencies Dependency updates labels Feb 14, 2025
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 14, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 14, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 14, 2025
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 14, 2025
mattlord
mattlord approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dbussink
Copy link
Contributor Author

@vmg I think we have to fix the sizegen assumptions here for map, as those have internally changed and have a different size now.

frouioui
frouioui reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile has to use the proper bootstrap version.

@dbussink
Fix bootstrap version in Makefile
6f6b2c2 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink
Copy link
Contributor Author

The Makefile has to use the proper bootstrap version.

Fixed!

@frouioui frouioui mentioned this pull request Feb 14, 2025
Closed
5 tasks
@frouioui
trigger ci
9417bf7 
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui mentioned this pull request Feb 14, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@frouioui frouioui frouioui approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Build/CI dependencies Pull requests that update a dependency file Type: Dependencies Dependency updates
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @mattlord @frouioui