feat: nicer errors

Signed-off-by: Andres Taylor <[email protected]>

go/summarize/summarize.go

@@ -25,6 +25,7 @@ import (
 	"time"
 
 	"github.com/alecthomas/chroma/quick"
+	"github.com/fatih/color"
 	"golang.org/x/term"
 )
 
@@ -43,9 +44,7 @@ func Run(files []string, hotMetric string, showGraph bool) {
 
 	for _, file := range files {
 		typ, err := getFileType(file)
-		if err != nil {
-			panic(err.Error())
-		}
+		exitIfError(err)
 		var w summarizer
 		var t traceSummary
 		switch typ {
@@ -60,10 +59,7 @@ func Run(files []string, hotMetric string, showGraph bool) {
 		default:
 			err = errors.New("unknown file type")
 		}
-
-		if err != nil {
-			panic(err.Error())
-		}
+		exitIfError(err)
 
 		if w != nil {
 			workers = append(workers, w)
@@ -76,22 +72,17 @@ func Run(files []string, hotMetric string, showGraph bool) {
 	traceCount := len(traces)
 	if traceCount <= 0 {
 		s, err := printSummary(hotMetric, workers)
-		if err != nil {
-			panic(err.Error())
-		}
+		exitIfError(err)
 		if showGraph {
 			err := renderQueryGraph(s)
-			if err != nil {
-				panic(err.Error())
-			}
+			exitIfError(err)
 		}
 		return
 	}
 
 	err := checkTraceConditions(traces, workers, hotMetric)
-	if err != nil {
-		panic(err.Error())
-	}
+	exitIfError(err)
+
 	switch traceCount {
 	case 1:
 		printTraceSummary(os.Stdout, terminalWidth(), highlightQuery, traces[0])
@@ -100,6 +91,15 @@ func Run(files []string, hotMetric string, showGraph bool) {
 	}
 }
 
+func exitIfError(err error) {
+	if err == nil {
+		return
+	}
+	_, _ = color.New(color.FgRed).Fprintln(os.Stderr, err.Error())
+
+	os.Exit(1)
+}
+
 func printSummary(hotMetric string, workers []summaryWorker) (*Summary, error) {
 	s, err := NewSummary(hotMetric)
 	if err != nil {

go/summarize/utils.go

@@ -53,7 +53,7 @@ func getFileType(filename string) (fileType, error) {
 
 	token, err := decoder.Token()
 	if err != nil {
-		return unknownFile, fmt.Errorf("error reading token: %v", err)
+		return unknownFile, fmt.Errorf("error reading json token: %v", err)
 	}
 
 	if delim, ok := token.(json.Delim); !ok || delim != '{' {
@@ -66,7 +66,7 @@ func getFileType(filename string) (fileType, error) {
 
 	keyToken, err := decoder.Token()
 	if err != nil {
-		return unknownFile, fmt.Errorf("error reading key token: %v", err)
+		return unknownFile, fmt.Errorf("error reading json key token: %v", err)
 	}
 
 	key, ok := keyToken.(string)
@@ -76,7 +76,7 @@ func getFileType(filename string) (fileType, error) {
 
 	valueToken, err := decoder.Token()
 	if err != nil {
-		return unknownFile, fmt.Errorf("error reading value token: %v", err)
+		return unknownFile, fmt.Errorf("error reading json value token: %v", err)
 	}
 
 	if key == "fileType" {