Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testdata cleanup #85

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Testdata cleanup #85

merged 2 commits into from
Dec 9, 2024

Conversation

systay
Copy link
Contributor

@systay systay commented Dec 9, 2024

  • bugfix: make sure we have both vtconn and mysqlconnt
  • test: clean up testdata folder

@systay systay changed the title T Testdata cleanup Dec 9, 2024
@systay systay marked this pull request as ready for review December 9, 2024 07:16
rohit-nayak-ps
rohit-nayak-ps approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactror, the testdata files were getting confusing to use!

@systay systay merged commit cd0116b into vitessio:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@systay @rohit-nayak-ps