Database collations #489
Open
Database collations #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedvaziry
reviewed
Feb 22, 2025
| /** @var Database $db */ | ||
| $db = $service->handler(); | ||
|
|
||
| $db->syncDatabases(false); |
There was a problem hiding this comment.
We need a rollback mechanism and let the user to retry if this fails
saeedvaziry
reviewed
Feb 22, 2025
app/Models/Database.php
Outdated
| public function getStatusText(): string | ||
| { | ||
| return match ($this->status) { | ||
| DatabaseStatus::READY => 'Ready', |
|
@RichardAnderson I added some unit tests. they might fail now but it is expected to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls the collation and charset information from the database on install.
Syncs the charset information to existing DBs
Provides the ability to specify the charset.
Partially implements synching of DBs.