Removing api router scope #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f healthcheck route
pablovieiras
approved these changes
Oct 15, 2019
rlrezende
approved these changes
Oct 15, 2019
|
É necessário modificar incrementar uma nova versão no package.json |
beeblebrox3
requested changes
Oct 19, 2019
| return res | ||
| .status(200) | ||
| .json({ message: `Hello, I'm attiv and I'm here to help you develop software faster, robust and secure.` }); | ||
| .json({ message: `Hello, I'm attiv and i'm here to help you develop software faster, robust and secure. The process is running for ${Math.floor(process.uptime()) / 60} minutes` }); |
There was a problem hiding this comment.
There's another "I'm" that can be replaced by "i'm".
Another suggestion is keep uptime in seconds.
There was a problem hiding this comment.
It's not better keep it in minutes? Why do you prefer in seconds?
I think the number in seconds will be too big if all the things are running ok, making dificult to human readability
There was a problem hiding this comment.
I think is more common. With minutes we have the same problem when it's running for a long time, I think. Maybe add the startup time helps 🤔
rlrezende
approved these changes
Oct 28, 2019
|
@beeblebrox3 eu alterei conforme requisitado! |
beeblebrox3
approved these changes
Oct 30, 2019
|
@rlrezende @beeblebrox3 O que precisamos para mesclar este? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other changes (e.g. bug fixes, UI tweaks, refactors)
Related Tickets
#31