Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CMake script #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added CMake script #5

wants to merge 1 commit into from

Conversation

0xeb
Copy link
Contributor

@0xeb 0xeb commented Nov 28, 2024

First version of CMake script

@vkazanov
Copy link
Owner

Hi! Thanks for the suggestion!

I might merge this after checking. And if we are to extend the project then adding a comment in the README would be nice.

But why do you think this simple demo project needs cmake at all? The Makefile is trivial.

@vkazanov
Copy link
Owner

vkazanov commented Dec 2, 2024

@0xeb , can you pls expand a bit based on my question above? Thanks

@0xeb
Copy link
Contributor Author

0xeb commented Dec 3, 2024

Good question and thanks for your patience. I wanted to add the CMake script as a first step to start porting this project to support Windows too.

Are you interested in supporting Windows?

If so, then CMake script will make sense as it is a universal way to prep for building, etc.

@vkazanov
Copy link
Owner

hey, sorry for a delayed answer! December is always a busy month for me.

Either way, I don't mind support Windows per se as long as the original makefile keeps working, and instructions are provided in the README file for both build approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants