Hw19.2 #28
Open
Hw19.2 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2024 13:51
antohaUa
requested changes
Dec 21, 2024
Comment on lines
+42
to
+49
| except HTTPError as http_err: | ||
| _log.error(f'HTTP error: {http_err}') | ||
| except Timeout as time_err: | ||
| _log.error(f'Timeout error: {time_err}') | ||
| except FileNotFoundError as file_err: | ||
| _log.error(f'File not found: - {file_err}') | ||
| except Exception as err: | ||
| _log.error(f'An unexpected error occurred: {err}') |
There was a problem hiding this comment.
Better to add helper function do_request and put all request error handling there. No sense to keep duplicate code for upload/get/delete operations
Other error handling like FileNotFound could be placed to main block
vladspirin
added
the
need to improve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.