HW21 #31
HW21 #31
Conversation
| try: | ||
| with open(filename, 'r') as file: | ||
| for line_number, line in enumerate(file, start=1): | ||
| if 'Key TSTFEED0300|7E3E|0400' in line: |
There was a problem hiding this comment.
Better to avoid hardcodes - certain key string better to accept as function parameter
| if 'Key TSTFEED0300|7E3E|0400' in line: | ||
| match = re.search(r'Timestamp (\d{2}:\d{2}:\d{2})', line) | ||
| if match: | ||
| try: |
There was a problem hiding this comment.
No sense in this try - except - better catch all errors within analyze_heartbeat function try-except block
| line_number_next, timestamp_next = timestamps[i + 1] | ||
| delta = (timestamp_current - timestamp_next).total_seconds() | ||
|
|
||
| if 31 < delta < 33: |
There was a problem hiding this comment.
31 and 32 better to place to the top as constants
| f'at line {line_number_current} ({timestamp_current})' | ||
| ) | ||
| elif delta >= 33: | ||
| _log.error( |
There was a problem hiding this comment.
I have in log such line
2025-01-08 21:40:56,349 - ERROR - Critical heartbeat delay: 35.0 seconds at line 1189 (1900-01-01 04:51:17)
1900-01-01 looks as bug. Please fix it
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| analyze_heartbeat('hblog.txt') |
There was a problem hiding this comment.
Here better to define as input parameters input_log_txt_filename, output_log_filename, certain Key string.
Logger creation could be organized then as separate function to accept output filename
vladspirin
added
the
need to improve
No description provided.