v: minor optimizations on cmd/v (#22878)

vlib/builtin/builtin.v

@@ -24,6 +24,7 @@ struct VCastTypeIndexName {
 // will be filled in cgen
 __global as_cast_type_indexes []VCastTypeIndexName
 
+@[direct_array_access]
 fn __as_cast(obj voidptr, obj_type int, expected_type int) voidptr {
 	if obj_type != expected_type {
 		mut obj_name := as_cast_type_indexes[0].tname.clone()

vlib/v/ast/ast.v

@@ -2245,9 +2245,19 @@ pub fn (expr Expr) is_pure_literal() bool {
 
 pub fn (expr Expr) is_auto_deref_var() bool {
 	return match expr {
-		Ident { expr.obj is Var && expr.obj.is_auto_deref }
-		PrefixExpr { expr.op == .amp && expr.right.is_auto_deref_var() }
-		else { false }
+		Ident {
+			if expr.obj is Var {
+				expr.obj.is_auto_deref
+			} else {
+				false
+			}
+		}
+		PrefixExpr {
+			expr.op == .amp && expr.right.is_auto_deref_var()
+		}
+		else {
+			false
+		}
 	}
 }
 

vlib/v/ast/scope.v

@@ -165,6 +165,7 @@ pub fn (mut s Scope) register(obj ScopeObject) {
 
 // returns the innermost scope containing pos
 // pub fn (s &Scope) innermost(pos int) ?&Scope {
+@[direct_array_access]
 pub fn (s &Scope) innermost(pos int) &Scope {
 	if s.contains(pos) {
 		// binary search

vlib/v/checker/checker.v

@@ -1512,10 +1512,8 @@ fn (mut c Checker) selector_expr(mut node ast.SelectorExpr) ast.Type {
 
 	using_new_err_struct_save := c.using_new_err_struct
 	// TODO: remove; this avoids a breaking change in syntax
-	if node.expr is ast.Ident {
-		if node.expr.str() == 'err' {
-			c.using_new_err_struct = true
-		}
+	if node.expr is ast.Ident && node.expr.name == 'err' {
+		c.using_new_err_struct = true
 	}
 
 	// T.name, typeof(expr).name

vlib/v/checker/fn.v

@@ -2875,6 +2875,7 @@ fn (mut c Checker) go_expr(mut node ast.GoExpr) ast.Type {
 	}
 }
 
+@[direct_array_access]
 fn (mut c Checker) set_node_expected_arg_types(mut node ast.CallExpr, func &ast.Fn) {
 	if node.expected_arg_types.len == 0 {
 		start_idx := if func.is_method { 1 } else { 0 }

vlib/v/checker/struct.v

@@ -177,8 +177,9 @@ fn (mut c Checker) struct_decl(mut node ast.StructDecl) {
 				c.check_valid_snake_case(field.name, 'field name', field.pos)
 			}
 			sym := c.table.sym(field.typ)
+			field_name, field_name_len := field.name, field.name.len
 			for j in 0 .. i {
-				if field.name == node.fields[j].name {
+				if field_name_len == node.fields[j].name.len && field_name == node.fields[j].name {
 					c.error('field name `${field.name}` duplicate', field.pos)
 				}
 			}

vlib/v/comptime/comptimeinfo.v

@@ -51,13 +51,14 @@ pub fn (mut ct ComptimeInfo) is_comptime_variant_var(node ast.Ident) bool {
 // get_ct_type_var gets the comptime type of the variable (.generic_param, .key_var, etc)
 @[inline]
 pub fn (mut ct ComptimeInfo) get_ct_type_var(node ast.Expr) ast.ComptimeVarKind {
-	return if node is ast.Ident && node.obj is ast.Var {
-		(node.obj as ast.Var).ct_type_var
+	if node is ast.Ident {
+		if node.obj is ast.Var {
+			return node.obj.ct_type_var
+		}
 	} else if node is ast.IndexExpr {
 		return ct.get_ct_type_var(node.left)
-	} else {
-		.no_comptime
 	}
+	return .no_comptime
 }
 
 @[inline]

vlib/v/gen/c/struct.v

@@ -229,8 +229,9 @@ fn (mut g Gen) struct_init(node ast.StructInit) {
 			g.is_shared = field.typ.has_flag(.shared_f)
 			if mut sym.info is ast.Struct {
 				mut found_equal_fields := 0
+				field_name, field_name_len := field.name, field.name.len
 				for mut sifield in sym.info.fields {
-					if sifield.name == field.name {
+					if sifield.name.len == field_name_len && sifield.name == field_name {
 						found_equal_fields++
 						break
 					}